substrate: a set stays a set, so the standing rides every conclusion again #78

Merged
larandar merged 1 commit from tango/standing-dedup-rides-the-substrate into main 2026-08-13 07:25:52 +00:00
Owner

jostoph-rs 029a102 -> 4998043: upstream #5 fixed resolve so identical
effects collapse on the way out (and an effect carries with its reason,
so an overruled allowance no longer keeps what it asked for).

That is the dedup eb7d6f0 worked around at the policy level with an
agg-min witness, on the accurate observation that the substrate of the
day did not collapse them. It does now, so the workaround is reverted:
the standing is attached to every conclusion, as the original comment
declared, and the substrate hands back one comment however many
findings asked for it. every_finding_lands_in_one_comment stays green
under both the old shape's reason and the new one.

nix flake check green; cargo fmt/clippy -D warnings clean.

Co-Authored-By: Claude Fable 5 [email protected]

jostoph-rs 029a102 -> 4998043: upstream #5 fixed resolve so identical effects collapse on the way out (and an effect carries with its reason, so an overruled allowance no longer keeps what it asked for). That is the dedup eb7d6f0 worked around at the policy level with an agg-min witness, on the accurate observation that the substrate of the day did not collapse them. It does now, so the workaround is reverted: the standing is attached to every conclusion, as the original comment declared, and the substrate hands back one comment however many findings asked for it. every_finding_lands_in_one_comment stays green under both the old shape's reason and the new one. nix flake check green; cargo fmt/clippy -D warnings clean. Co-Authored-By: Claude Fable 5 <[email protected]>
jostoph-rs 029a102 -> 4998043: upstream #5 fixed resolve so identical
effects collapse on the way out (and an effect carries with its reason,
so an overruled allowance no longer keeps what it asked for).

That is the dedup eb7d6f0 worked around at the policy level with an
agg-min witness, on the accurate observation that the substrate of the
day did not collapse them. It does now, so the workaround is reverted:
the standing is attached to every conclusion, as the original comment
declared, and the substrate hands back one comment however many
findings asked for it. every_finding_lands_in_one_comment stays green
under both the old shape's reason and the new one.

nix flake check green; cargo fmt/clippy -D warnings clean.

Co-Authored-By: Claude Fable 5 <[email protected]>
larandar deleted branch tango/standing-dedup-rides-the-substrate 2026-08-13 07:25:52 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Ting/Jostoph!78
No description provided.