substrate: a set stays a set, so the standing rides every conclusion again #78
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Meta/Campaign
Meta/Epic
Meta/Session
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
Reviewed/Confirmed
Reviewed/Curated
Reviewed/Duplicate
Reviewed/Invalid
Reviewed/Won't Fix
Scope/Campaign
Status/Abandoned
Status/Blocked
Status/Conflicted
Status/In Progress
Status/In Review
Status/Need Grooming
Status/Need More Info
Status/Ready
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Ting/Jostoph!78
Loading…
Reference in a new issue
No description provided.
Delete branch "tango/standing-dedup-rides-the-substrate"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
jostoph-rs 029a102 -> 4998043: upstream #5 fixed resolve so identical
effects collapse on the way out (and an effect carries with its reason,
so an overruled allowance no longer keeps what it asked for).
That is the dedup
eb7d6f0worked around at the policy level with anagg-min witness, on the accurate observation that the substrate of the
day did not collapse them. It does now, so the workaround is reverted:
the standing is attached to every conclusion, as the original comment
declared, and the substrate hands back one comment however many
findings asked for it. every_finding_lands_in_one_comment stays green
under both the old shape's reason and the new one.
nix flake check green; cargo fmt/clippy -D warnings clean.
Co-Authored-By: Claude Fable 5 [email protected]