Ting/Jostoph
Watch
2
0
Fork
You've already forked Jostoph
 2
Code Issues 57 Pull requests Projects Releases Packages Wiki Activity Actions

Verify law 13: the steward moves the tracker states it owns (in-review, conflicted) and derives blocked #25

New issue
Open
opened 2026-08-11 16:05:16 +00:00 by agent.teyla · 2 comments
agent.teyla commented 2026-08-11 16:05:16 +00:00
Contributor
Copy link

In scope

Declared effects in src/policy.rs for the label transitions law 13 assigns to the steward:

  • in-review on every ticket a PR body closes (not just the lead one), when the PR opens against fastlane.
  • conflicted when the steward's declared rebase/update of a PR fails, with evidence in a comment; back to in-review on the fix push.
  • blocked as a derived-only overlay from open Blocked by edges — never hand-set, purely informative.

Label names parameterized in nix/policy.nix.

Out of scope

  • Performing the label mutations (declared effects only, consistent with the answering perimeter).
  • The hand-set overlays (needs-decision) and the curated PR label — those have other movers.
  • Creating the labels on the forge — that is desired-state conformance (pipeline_labels on the forge-conformance trait).

Boundary

Depends on the law-9 body parsing (the set of tickets a PR closes) and on dependency edges if the payload carries them; where the webhook payload is insufficient, the rule declares what it would need rather than reaching for a token.

Acceptance

  • A PR opening with Closes #7 declares forgejo.label effects setting in-review on #7.
  • A failed declared update declares conflicted plus an evidence comment.
  • blocked is only ever derived; no rule accepts it as input from a hand-set label.
  • nix flake check passes.
## In scope Declared effects in `src/policy.rs` for the label transitions law 13 assigns to the steward: - `in-review` on every ticket a PR body closes (not just the lead one), when the PR opens against fastlane. - `conflicted` when the steward's declared rebase/update of a PR fails, with evidence in a comment; back to `in-review` on the fix push. - `blocked` as a **derived-only** overlay from open *Blocked by* edges — never hand-set, purely informative. Label names parameterized in `nix/policy.nix`. ## Out of scope - Performing the label mutations (declared effects only, consistent with the answering perimeter). - The hand-set overlays (`needs-decision`) and the `curated` PR label — those have other movers. - Creating the labels on the forge — that is desired-state conformance (`pipeline_labels` on the `forge-conformance` trait). ## Boundary Depends on the law-9 body parsing (the set of tickets a PR closes) and on dependency edges if the payload carries them; where the webhook payload is insufficient, the rule declares what it would need rather than reaching for a token. ## Acceptance - A PR opening with `Closes #7` declares `forgejo.label` effects setting `in-review` on #7. - A failed declared update declares `conflicted` plus an evidence comment. - `blocked` is only ever derived; no rule accepts it as input from a hand-set label. - `nix flake check` passes.
codexo commented 2026-08-16 06:21:57 +00:00
Contributor
Copy link

Grooming state: Stale label vocabulary resolved; implementation ready.
Evidence: Ting/Ting#25 ratified the canonical organisation vocabulary and completed its cutover.
Scope correction: Declare Status/In Review, Status/Conflicted, and derived-only Status/Blocked instead of the unprefixed names in this body. Keep needs-decision semantically distinct from Status/Need More Info.
Delivery boundary: Declared effects and tests only; performing label mutations remains out of scope.

<!-- codexo:groom:v1 --> **Grooming state:** Stale label vocabulary resolved; implementation ready. **Evidence:** [Ting/Ting#25](https://jo.et0.pw/Ting/Ting/issues/25) ratified the canonical organisation vocabulary and completed its cutover. **Scope correction:** Declare Status/In Review, Status/Conflicted, and derived-only Status/Blocked instead of the unprefixed names in this body. Keep needs-decision semantically distinct from Status/Need More Info. **Delivery boundary:** Declared effects and tests only; performing label mutations remains out of scope.
larandar commented 2026-09-20 03:47:56 +00:00
Owner
Copy link

Audit 2026-09-19/20, G23: reconcile this record and its implementation to the ratified Status/* vocabulary from grooming comment 6802 and Ting/Ting#25. Replace stale in-review, conflicted, and blocked terminology with Status/In Review, Status/Conflicted, and derived-only Status/Blocked; keep Status/Need More Info distinct from needs-decision semantics. This comment records the required body/label reconciliation without reopening the ratified vocabulary.

<!-- larandar:groom:v1 --> Audit 2026-09-19/20, G23: reconcile this record and its implementation to the ratified Status/* vocabulary from grooming comment 6802 and Ting/Ting#25. Replace stale `in-review`, `conflicted`, and `blocked` terminology with `Status/In Review`, `Status/Conflicted`, and derived-only `Status/Blocked`; keep `Status/Need More Info` distinct from needs-decision semantics. This comment records the required body/label reconciliation without reopening the ratified vocabulary.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fastlane
tango/103-lifecycle-audit
No results found.
Labels
Clear labels
  
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Meta/Campaign
Campaign grouping node; dependencies name its direct Epics

  
Meta/Epic
Epic grouping node; dependencies name its direct Sessions

  
Meta/Session
Session delivery bundle; dependencies name its direct leaf issues

  
Priority/Critical
The priority is critical

  
Priority/High
The priority is high

  
Priority/Low
The priority is low

  
Priority/Medium
The priority is medium

  
Reviewed/Confirmed
Issue has been confirmed

  
Reviewed/Curated
PR LABEL: merge by rebase/ff to preserve the commit line; absence means squash. Set by the AUTHOR. (Curation itself is a duty on every PR — the label only picks the merge style.)

  
Reviewed/Duplicate
This issue or pull request already exists

  
Reviewed/Invalid
Invalid issue

  
Reviewed/Won't Fix
This issue won't be fixed

  
Scope/Campaign
Umbrella issue grouping a coherent multi-issue campaign.

  
Status/Abandoned
Somebody has started to work on this but abandoned work

  
Status/Blocked
Something is blocking this issue or pull request

  
Status/Conflicted
STATE: steward rebase failed; work returned to its agent, with evidence.

  
Status/In Progress
STATE: claimed, workspace active. Exactly one assignee, or none when idle.

  
Status/In Review
STATE: PR open against fastlane. Set by steward (PR webhook).

  
Status/Need Grooming
Issue body and comments do not yet conform to the Deliverable record; grooming required.

  
Status/Need More Info
Feedback is required to reproduce issue or to continue work

  
Status/Ready
Ready for execution; no known blocker prevents useful work from starting.

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Meta/Campaign
Meta/Epic
Meta/Session
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
Reviewed/Confirmed
Reviewed/Curated
Reviewed/Duplicate
Reviewed/Invalid
Reviewed/Won't Fix
Scope/Campaign
Status/Abandoned
Status/Blocked
Status/Conflicted
Status/In Progress
Status/In Review
Status/Need Grooming
Status/Need More Info
Status/Ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Ting/Jostoph#25
No description provided.