Effector doubles the canonical marker in created comments (classify prepends an already-marked body) #44

New issue

Closed

opened 2026-09-02 08:44:33 +00:00 by larandar · 0 comments

larandar commented

2026-09-02 08:44:33 +00:00

Owner

Proposal

First live pass of Slice 1 over this tracker (2026-09-02, 43 open issues) created 43 canonical comments whose body carries the  marker twice. Convergence is unaffected (has_canonical_marker still matches; reruns no-op), but the rendered projection is malformed.

Design

Contract seam between currycomb-projection and currycomb-effector: desired_body_markdown already embeds the marker as the first line of body_markdown (crates/currycomb-projection/src/canonical_comment.rs). classify in crates/currycomb-effector/src/apply.rs then prepends marker again — compensation for its own test fixture (decl_create) which passed a marker-free body_markdown. The declaration is correct; the effector must treat body_markdown as authoritative and post it verbatim.

Tasks

classify Create branch uses body_markdown as-is; drop the marker prepend
fixture decl_create carries a marker-embedded body like the real projection
assert the recorded create body contains the marker exactly once

Requirement scenario

GIVEN a canonical_comment.create declaration from the projection, WHEN cc-apply posts it, THEN the comment body equals body_markdown byte-for-byte and contains exactly one canonical marker. Repaired on the tracker by deleting marker-bearing canonical comments and re-running reconcile+apply.

Refs #43 — found while running Slice 1 against this tracker.

## Proposal First live pass of Slice 1 over this tracker (2026-09-02, 43 open issues) created 43 canonical comments whose body carries the `` marker twice. Convergence is unaffected (`has_canonical_marker` still matches; reruns no-op), but the rendered projection is malformed. ## Design Contract seam between `currycomb-projection` and `currycomb-effector`: `desired_body_markdown` already embeds the marker as the first line of `body_markdown` (`crates/currycomb-projection/src/canonical_comment.rs`). `classify` in `crates/currycomb-effector/src/apply.rs` then prepends `marker` again — compensation for its own test fixture (`decl_create`) which passed a marker-free `body_markdown`. The declaration is correct; the effector must treat `body_markdown` as authoritative and post it verbatim. ## Tasks - [ ] `classify` Create branch uses `body_markdown` as-is; drop the marker prepend - [ ] fixture `decl_create` carries a marker-embedded body like the real projection - [ ] assert the recorded create body contains the marker exactly once ## Requirement scenario GIVEN a `canonical_comment.create` declaration from the projection, WHEN `cc-apply` posts it, THEN the comment body equals `body_markdown` byte-for-byte and contains exactly one canonical marker. Repaired on the tracker by deleting marker-bearing canonical comments and re-running reconcile+apply. Refs #43 — found while running Slice 1 against this tracker.

larandar referenced this issue from a commit

2026-09-02 08:46:05 +00:00

Effector posts canonical body verbatim; stops doubling the marker

larandar referenced this issue from a pull request that will close it,

2026-09-02 08:46:15 +00:00

Effector posts canonical body verbatim; stops doubling the marker #45

larandar closed this issue

2026-09-02 08:51:55 +00:00